Cli,Desktop,Mobile: Fix sync reported as in progress if an error occurs while removing sync locks #11188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors
Synchronizer.start
to ensure that its cleanup logic runs, even if there is an uncaughtError
. This fixes an issue originally reported on the forum — an error while removing sync locks could prevent sync cleanup logic from running.Testing plan
Locally, I have verified that the following automated test passes:
Show test
This test is not included in this pull request because it relies on
.spyOn
to mock a method ofLockHandler
. This seems fragile and likely to break in the future, particularly if sync locks are changed significantly or removed.Additionally, I have verified that a Dropbox sync completes successfully and reports the number of fetched and created items.